Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add wakeup for the Linak DPG1C controller #370

Merged
merged 7 commits into from
Dec 25, 2023
Merged

add wakeup for the Linak DPG1C controller #370

merged 7 commits into from
Dec 25, 2023

Conversation

newAM
Copy link
Owner

@newAM newAM commented Nov 20, 2023

CC #369

Copy link

@kaml123 kaml123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also propose to add self.wakeup() inside async def connect(self):

@newAM newAM force-pushed the add-wakeup branch 2 times, most recently from 26bec6d to 4b5e457 Compare December 19, 2023 20:49
@coveralls
Copy link

Coverage Status

coverage: 88.347% (+0.2%) from 88.122%
when pulling 419bb6a on add-wakeup
into cd43c75 on main.

@newAM
Copy link
Owner Author

newAM commented Dec 19, 2023

@abmantis if you have time your input here would be great since you maintain the HASS component. Do you know of any problems with this approach?

I tried this with my unmodified desk/controller and found no issues sending the wakeup command, but it's always good to double check :)

@abmantis
Copy link
Contributor

Sorry for the delay in replying @newAM ! I will try to test it over the weekend.
Is it possible to bump the major version of this lib when releasing this? That way, I can delay HA from using it. I've had quite a few reports from users regarding bluetooth instability (not related to this lib) and have an improvement that I want to get into the next release of HA. I would prefer to avoid adding this as a possible cause of extra unknown issues before the current ones are solved 😅

If you are fine with bumping the major version of the lib, than feel free to merge this as it will not affect HA for now! Later, if I find any issues during tests we can work on them :)

@newAM newAM merged commit b4c6776 into main Dec 25, 2023
@newAM newAM deleted the add-wakeup branch December 25, 2023 20:43
@datbilling
Copy link
Contributor

Hi @abmantis, I was just wondering if you had time yet to test this to see if it can be added into HA?

@abmantis
Copy link
Contributor

Hi @abmantis, I was just wondering if you had time yet to test this to see if it can be added into HA?

Yes, it worked fine on my desk (not DPG1C) and should be released with HA 2024.2!

@datbilling
Copy link
Contributor

Hi @abmantis, I was just wondering if you had time yet to test this to see if it can be added into HA?

Yes, it worked fine on my desk (not DPG1C) and should be released with HA 2024.2!

Ok perfect, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants